chore: Replace SharpZipLib TarArchive helper class with TarOutputStream #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Probably we can change the method to |
HofmeisterAn
deleted the
feature/improve-docker-image-build-error-message
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Replaces the TarArchive helper class with the TarOutputStream.
Why is it important?
This PR allows us to read the input file before creating the tar entry. In some cases (e.g. the input file is used by another process), we cannot read the file contents. The SharpZipLib's
TarArchive.WriteEntry(TarEntry, bool)helper method creates and adds the tar entry before reading the file. In the case mentioned above, this will throw aTarExceptionthat hides the underlying exception (issue).For a better development experience, we replace the helper class / method. In case of an error, developers will get the underlying error.
Related issues
-